Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added poller modules to ceraos.yaml #7470

Merged
merged 3 commits into from Oct 24, 2017
Merged

Conversation

barryodonovan
Copy link
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Disabled most poller modules in ceraos.yaml definition file.
None of the disabled modules apply to Ceragon radios and on some firmwares the repeated extra SNMP queries can cause the SNMP daemon to hang requiring a power cycle to restore functionality.
The polling time reduces from >150 seconds in many cases and >300 in some to ~40 seconds.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2017

CLA assistant check
All committers have signed the CLA.

@laf
Copy link
Member

laf commented Oct 11, 2017

You only need to disable or enable the ones not done by default so a lot of these can be removed.

Worth adding the discovery ones in as well?

@barryodonovan
Copy link
Contributor Author

@laf
I've disabled all those which are globally enabled by default. As a result of doing this I've realised that I had disabled many modules globally when I first built my system but didn't understand the correct approach to take. I am going to go over the other devices I use and i may open a similar PR for modules I am sure are not applicable though in my experience the ceragon are most sensitive to SNMP crashing due to excessive polling.

@laf
Copy link
Member

laf commented Oct 15, 2017

@barryodonovan Thanks for the update. However a lot of these are already disabled in defaults so they don't need to be specified here. Especially cisco- based ones.

@murrant
Copy link
Member

murrant commented Oct 20, 2017

@barryodonovan go to the webui and you can see what is enabled/disabled easily. Then change only the ones needed.

@barryodonovan
Copy link
Contributor Author

barryodonovan commented Oct 21, 2017 via email

@laf
Copy link
Member

laf commented Oct 21, 2017

@barryodonovan Maybe the docs are wrong :( But you can find all defaults in includes/defaults.inc.php

@barryodonovan
Copy link
Contributor Author

barryodonovan commented Oct 22, 2017 via email

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@@ -10,4 +10,37 @@ discovery:
- sysObjectId:
- .1.3.6.1.4.1.2281
poller_modules:
wifi: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come wifi has been disabled?

@laf
Copy link
Member

laf commented Oct 24, 2017

One question, are these now all disabled as they aren't supported or is this personal choice?

@barryodonovan
Copy link
Contributor Author

barryodonovan commented Oct 24, 2017 via email

@barryodonovan
Copy link
Contributor Author

barryodonovan commented Oct 24, 2017 via email

@laf laf merged commit fea6351 into librenms:master Oct 24, 2017
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants