New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve CentOS 7 and Ubuntu 16 rrdcached installation instructions #7473

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Oct 11, 2017

I tried to get these to as few of steps as possible.
Ubuntu starts the service during installation, so it won't have proper permissions/settings until after you restart it.
CentOS doesn't need epel (it doesn't have rrdtool in it) or permissions fixes. Move run files to /run directory to save a lot of steps and be similar to other platforms. Skipping the touch allows us to skip daemon-reload

Thanks to @kkrumm1 for work on this and testing.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

docs: improve CentOS 7 and Ubuntu 16 rrdcached installation instructions
I tried to get these to as few of steps as possible.
Ubuntu starts the service during installation, so it won't have proper permissions/settings until after you restart it.
CentOS doesn't need epel (it doesn't have rrdtool in it) or permissions fixes.  Move run files to /run directory to save a lot of steps and be similar to other platforms. Skipping the touch allows us to skip daemon-reload
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 11, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 11, 2017

The inspection completed: No new issues

@laf laf merged commit 3d41019 into librenms:master Oct 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:rrdcached-docs branch Oct 11, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.