New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to display ok/warning/critical alerts only #7484

Merged
merged 3 commits into from Oct 15, 2017

Conversation

Projects
None yet
4 participants
@rmedlyn
Contributor

rmedlyn commented Oct 13, 2017

Adds options to the alert widget to allow users to display alerts by specific severity in addition to displaying alerts above a severity threshold.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Oct 13, 2017

Member

can you post a screenshot of how this looks?

Member

kkrumm1 commented Oct 13, 2017

can you post a screenshot of how this looks?

@rmedlyn

This comment has been minimized.

Show comment
Hide comment
@rmedlyn

rmedlyn Oct 13, 2017

Contributor

View of an alerts widget from the dashboard:
librenms-alerts-warning-only-dash-view

View of an alerts widget in edit mode:
librenms-alerts-warning-only-edit-dash-view

Contributor

rmedlyn commented Oct 13, 2017

View of an alerts widget from the dashboard:
librenms-alerts-warning-only-dash-view

View of an alerts widget in edit mode:
librenms-alerts-warning-only-edit-dash-view

@rmedlyn

This comment has been minimized.

Show comment
Hide comment
@rmedlyn

rmedlyn Oct 13, 2017

Contributor

Here are the current views for reference:
librenms-alerts-current-dash-view

librenms-alerts-current-edit-dash-view

Contributor

rmedlyn commented Oct 13, 2017

Here are the current views for reference:
librenms-alerts-current-dash-view

librenms-alerts-current-edit-dash-view

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Oct 13, 2017

Member

Awesome. I did a test pull and works perfectly.

Member

kkrumm1 commented Oct 13, 2017

Awesome. I did a test pull and works perfectly.

laf added some commits Oct 15, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 15, 2017

The inspection completed: No new issues

@laf laf merged commit 62867a6 into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@rmedlyn rmedlyn deleted the rmedlyn:add-display-severity-options branch Oct 16, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.