New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysname as filtering group for oxidized #7485

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@petracvv
Contributor

petracvv commented Oct 13, 2017

For networks without DNS names for their devices, it may be useful to have the ability to create oxidized groups based on the SNMP sysname as that is usually more descriptive than the IP address.

This pull request adds the ability to match groups on the sysname and still returns the standard three hostname, os and group attributes to oxidized.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 13, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Oct 13, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 348f501 into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@petracvv

This comment has been minimized.

Show comment
Hide comment
@petracvv

petracvv Oct 16, 2017

Contributor

Thanks for the merge!

Contributor

petracvv commented Oct 16, 2017

Thanks for the merge!

@petracvv petracvv deleted the petracvv:sysname_groups branch Oct 16, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 17, 2017

Member

Thanks for the PR :D

Member

laf commented Oct 17, 2017

Thanks for the PR :D

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.