New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improve Device Neighbour WebUI #7487

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@Rosiak
Contributor

Rosiak commented Oct 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Creates new device menu called Neighbours, which includes list(a table) and the map
  • Cleans up old neighbours UI code
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 14, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 14, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 14, 2017

Member

Great @Rosiak.

Also might be worthwhile to remove the SQL that requires remote device to be in LibreNMS.

Member

murrant commented Oct 14, 2017

Great @Rosiak.

Also might be worthwhile to remove the SQL that requires remote device to be in LibreNMS.

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Oct 14, 2017

Contributor

The current code used in the neighbours file doesn't require the remote device to be in libre, in order to display the relation. That's only the actual map afaik.

Contributor

Rosiak commented Oct 14, 2017

The current code used in the neighbours file doesn't require the remote device to be in libre, in order to display the relation. That's only the actual map afaik.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 15, 2017

Member

Like this, there might be some more things we can put under the neighbor tab.
A per-port neighbor entry might not be bad either.

Member

murrant commented Oct 15, 2017

Like this, there might be some more things we can put under the neighbor tab.
A per-port neighbor entry might not be bad either.

@murrant murrant merged commit a9ab96e into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.