New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Improve Zhone MXK Discovery #7488

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
3 participants
@Rosiak
Contributor

Rosiak commented Oct 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
fix #7429

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 15, 2017

Member

@Rosiak think the test file needs to be slms_1

Member

laf commented Oct 15, 2017

@Rosiak think the test file needs to be slms_1

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Oct 15, 2017

Contributor

Ah thanks laf, wondered why the test's failed.

Contributor

Rosiak commented Oct 15, 2017

Ah thanks laf, wondered why the test's failed.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 15, 2017

The inspection completed: 1 new issues, 7 updated code elements

scrutinizer-notifier commented Oct 15, 2017

The inspection completed: 1 new issues, 7 updated code elements

@laf laf merged commit 81667b9 into librenms:master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added a commit that referenced this pull request Oct 16, 2017

laf added a commit that referenced this pull request Oct 16, 2017

Revert "bug: fail isPingable if fping errors" (#7496)
* Revert "fix: Fixed clickatell alert transport (#7446)"

This reverts commit 9774acd.

* Revert "newdevice: Added support for Eaton ATS devices (#7448)"

This reverts commit 1318e58.

* Revert "newdevice: Updated Zhone MXK detection (#7488)"

This reverts commit 81667b9.

* Revert "docs: Added HipChat V2 WebUI Config Example (#7486)"

This reverts commit a31eaa9.

* Revert "fix: Fail isPingable if fping errors (#7426)"

This reverts commit 1998845.
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.