New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Add ability to mark all notifications as read #7489

Merged
merged 4 commits into from Nov 29, 2017

Conversation

Projects
None yet
4 participants
@Rosiak
Contributor

Rosiak commented Oct 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes:
https://community.librenms.org/t/ability-to-mark-all-notifications-as-re
ad/2368/1

However it's done in a slightly ugly way with the window.location.reload() as my JS skills are lacking, and it's late. So please give some input :)

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 16, 2017

Member

Found an issue, if you keep clicking the button, it keeps adding notifications_attribs entries.

Also, why is this admin only?

Member

murrant commented Oct 16, 2017

Found an issue, if you keep clicking the button, it keeps adding notifications_attribs entries.

Also, why is this admin only?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf
Member

laf commented Oct 25, 2017

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Nov 5, 2017

Contributor

Seems like this should be possible for every user, I agree on that.
That said I haven't had the time to look further into it - I'll try to see if I have a change in the coming week or the week after.

Contributor

Rosiak commented Nov 5, 2017

Seems like this should be possible for every user, I agree on that.
That said I haven't had the time to look further into it - I'll try to see if I have a change in the coming week or the week after.

dataType: "json",
success: function (data) {
if( data.status == "ok" ) {
window.location.reload()

This comment has been minimized.

@murrant

murrant Nov 23, 2017

Member

Should be able to hide all unread notifications and update the notification counts in jquery.

Makes me miss Vue :)

@murrant

murrant Nov 23, 2017

Member

Should be able to hide all unread notifications and update the notification counts in jquery.

Makes me miss Vue :)

murrant added some commits Nov 29, 2017

@murrant murrant changed the title from feature: Add ability to mark all notifications as read to webui: Add ability to mark all notifications as read Nov 29, 2017

@murrant murrant added the WebUI label Nov 29, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 29, 2017

The inspection completed: 561 Issues, 24 Patches

scrutinizer-notifier commented Nov 29, 2017

The inspection completed: 561 Issues, 24 Patches

@murrant murrant merged commit 461b39e into librenms:master Nov 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.