New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improve APC rPDU2 Sensor Discovery #7490

Merged
merged 4 commits into from Nov 15, 2017

Conversation

Projects
None yet
4 participants
@Rosiak
Contributor

Rosiak commented Oct 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
fixes:
https://community.librenms.org/t/apc-pdu-environment-sensor/2360

Also removed some unused variables in the state code.
In general our APC code needs cleanup, but I won't head up that task right now..

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 15, 2017

Member

How come this hasn't been done in yaml, I've only had a quick look and it seems all do-able.

Member

laf commented Oct 15, 2017

How come this hasn't been done in yaml, I've only had a quick look and it seems all do-able.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf
Member

laf commented Oct 25, 2017

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Nov 5, 2017

Contributor
if ($data['rPDU2SensorTempHumidityStatusType'] != 'notInstalled') 

Is possible to do something like this in the yaml discovery?

Contributor

Rosiak commented Nov 5, 2017

if ($data['rPDU2SensorTempHumidityStatusType'] != 'notInstalled') 

Is possible to do something like this in the yaml discovery?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 5, 2017

Member

Not at present but you can do checks based on the returned value, is that helpful?

Member

laf commented Nov 5, 2017

Not at present but you can do checks based on the returned value, is that helpful?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 9, 2017

Member

We could do some arbitrary value checking like this:
valid: '{{ $rPDU2SensorTempHumidityStatusType }} != notInstalled`

Member

murrant commented Nov 9, 2017

We could do some arbitrary value checking like this:
valid: '{{ $rPDU2SensorTempHumidityStatusType }} != notInstalled`

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 15, 2017

Member

if ($data['rPDU2SensorTempHumidityStatusType'] != 'notInstalled')

Should now be possible. See hwg-ste / hwg-ste2 files for how to use it.

Member

laf commented Nov 15, 2017

if ($data['rPDU2SensorTempHumidityStatusType'] != 'notInstalled')

Should now be possible. See hwg-ste / hwg-ste2 files for how to use it.

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Nov 15, 2017

Contributor

Should be good-to-go now.

Contributor

Rosiak commented Nov 15, 2017

Should be good-to-go now.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 15, 2017

The inspection completed: No new issues

@laf laf merged commit 600b2f3 into librenms:master Nov 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.