New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added primary key to perf_times to improve DELETE performance on replicas using ROW based replication #7493

Merged
merged 10 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Oct 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Relies on #7446 so travis will fail until that's merged.

Replaces #7368

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 25, 2017

Member

Bump?

Member

laf commented Oct 25, 2017

Bump?

laf added some commits Oct 26, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 26, 2017

Member

Rebased.

Member

laf commented Oct 26, 2017

Rebased.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 30, 2017

Member

@laf your db_schema.yaml seems to re-order some of the fields, which is now taken into account for adding missing fields with the new validate. Perhaps, you need to start a fresh db.

Member

murrant commented Oct 30, 2017

@laf your db_schema.yaml seems to re-order some of the fields, which is now taken into account for adding missing fields with the new validate. Perhaps, you need to start a fresh db.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 30, 2017

Member

Dev install, I'd genuinely prefer not to start again :(

I'll manually fix.

Member

laf commented Oct 30, 2017

Dev install, I'd genuinely prefer not to start again :(

I'll manually fix.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 31, 2017

The inspection completed: 2 new issues, 6 updated code elements

scrutinizer-notifier commented Oct 31, 2017

The inspection completed: 2 new issues, 6 updated code elements

@laf laf merged commit cb33307 into librenms:master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-7368 branch Oct 31, 2017

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Added primary key to perf_times to improve DELETE performance on…
… replicas using ROW based replication (librenms#7493)

* fix: Added primary key to perf_times to improve DELETE performance on replicas using ROW based replication

* moved sql file

* moved sql file

* Rebased

* fixed schema

* moved sql file

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Added primary key to perf_times to improve DELETE performance on…
… replicas using ROW based replication (librenms#7493)

* fix: Added primary key to perf_times to improve DELETE performance on replicas using ROW based replication

* moved sql file

* moved sql file

* Rebased

* fixed schema

* moved sql file
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.