Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape sql credentials during install #7494

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@murrant
Copy link
Member

murrant commented Oct 16, 2017

Fixes https://community.librenms.org/t/problem-with-starting-install/2363 also, probably a security vulnerability.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant murrant changed the title fix: escape sql data during install fix: escape sql credentials during install Oct 16, 2017

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Oct 16, 2017

The inspection completed: No new issues

@laf laf added the Security label Oct 17, 2017

@laf laf merged commit 96ccc49 into librenms:master Oct 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:escape-passwords-install branch Oct 17, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.