New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for OEM ipmi sensors that returns unreadable values #7518

Merged
merged 2 commits into from Oct 20, 2017

Conversation

Projects
None yet
3 participants
@crcro
Contributor

crcro commented Oct 19, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

before: ipmi returned:
Enclosure Status | 0x2 | discrete | 0x0080| na | na | na | na | na | na
Health LED | 0x0 | discrete | 0x0080| na | na | na | na | na | na
Memory Status | 0x0 | discrete | 0x4180| na | na | na | na | na | na
Power Meter | 130 | Watts | ok | na | na | na | na | na | na
Temp 10 | 0.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 60.000 | 65.000
Temp 1 | 23.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 40.000 | 42.000 | 46.000
Temp 2 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 82.000 | 83.000
Temp 3 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 82.000 | 83.000
Temp 4 | 38.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 87.000 | 92.000
Temp 5 | 34.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 6 | 41.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 7 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 8 | 45.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 78.000 | 83.000
Temp 9 | 60.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 110.000 | 115.000
UID Light | 0x0 | discrete | 0x0080| na | na | na | na | na | na
Virtual Fan | 19.600 | percent | ok | na | na | na | na | na | na
VRM 1 | 0x0 | discrete | 0x0280| na | na | na | na | na | na
VRM 2 | 0x0 | discrete | 0x0280| na | na | na | na | na | na

which would create some health sensors with not sensor_class (resulting in emty entry in health web menu)

after: ipmi returns:

Power Meter | 132 | Watts | ok | na | na | na | na | na | na
Temp 10 | 0.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 60.000 | 65.000
Temp 1 | 23.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 40.000 | 42.000 | 46.000
Temp 2 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 82.000 | 83.000
Temp 3 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 82.000 | 83.000
Temp 4 | 37.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 87.000 | 92.000
Temp 5 | 34.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 6 | 41.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 7 | 40.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 85.000 | 90.000
Temp 8 | 45.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 78.000 | 83.000
Temp 9 | 60.000 | degrees C | ok | 0.000 | 0.000 | 0.000 | 0.000 | 110.000 | 115.000
Virtual Fan | 19.600 | percent | ok | na | na | na | na | na | na

and no more health sensors are added

@crcro crcro changed the title from fix: for OEM ipmi server that doesn't return unreadable values to fix: for OEM ipmi sensors that doesn't return unreadable values Oct 19, 2017

@crcro crcro changed the title from fix: for OEM ipmi sensors that doesn't return unreadable values to fix: for OEM ipmi sensors that returns unreadable values Oct 19, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 19, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 19, 2017

The inspection completed: No new issues

@laf laf merged commit 2a15da2 into librenms:master Oct 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.