New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for logmaster(ups vendors) os/devices #7524

Merged
merged 17 commits into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@alangregory
Contributor

alangregory commented Oct 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@alangregory

This comment has been minimized.

Show comment
Hide comment
@alangregory

alangregory Oct 20, 2017

Contributor

It seems that sysObjectId is used on hardware from differen ups sellers, is it possible to force the checking of sysDescr and sysObjectId?

Contributor

alangregory commented Oct 20, 2017

It seems that sysObjectId is used on hardware from differen ups sellers, is it possible to force the checking of sysDescr and sysObjectId?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 21, 2017

Member

zynos os does what you need.

Also, logo in png format should be 32x32

Member

laf commented Oct 21, 2017

zynos os does what you need.

Also, logo in png format should be 32x32

alangregory added some commits Oct 23, 2017

@alangregory

This comment has been minimized.

Show comment
Hide comment
@alangregory

alangregory Oct 23, 2017

Contributor

@laf ./scripts/pre-commit.php still shows errors on local dev. Is there some kind of cache for snmpsim ?

Contributor

alangregory commented Oct 23, 2017

@laf ./scripts/pre-commit.php still shows errors on local dev. Is there some kind of cache for snmpsim ?

@laf

You can delete RFC1628_UPS_MIB.MIB as we already have that, it's UPS-MIB.

Unless you need to, please move mibs/XPPC-MIB.mib into the mibs/logmaster/ dir and remove the .mib.

Remove the .mib from mibs/logmaster/UPSMATE.MIB

Is logmaster the correct OS name. We don't really want to use vendor names as the OS.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 23, 2017

Member

You might need to remove cache/os-defs.cache

Member

laf commented Oct 23, 2017

You might need to remove cache/os-defs.cache

@alangregory

This comment has been minimized.

Show comment
Hide comment
@alangregory

alangregory Oct 23, 2017

Contributor

XPPC-MIB ia a mib used by many vendors. Os is called logmaster.

Contributor

alangregory commented Oct 23, 2017

XPPC-MIB ia a mib used by many vendors. Os is called logmaster.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 23, 2017

Member

Thanks for the updates. Last question, do these devices not support the rfc1628 code we already have?

Member

laf commented Oct 23, 2017

Thanks for the updates. Last question, do these devices not support the rfc1628 code we already have?

@alangregory

This comment has been minimized.

Show comment
Hide comment
@alangregory

alangregory Oct 24, 2017

Contributor

Looks like 70% works with rfc1628 , so i'm only adding aditional sensors. Is it possible to overide realtionship from some states ? Like:

array(
array('value' => 1, 'generic' => 3, 'graph' => 0, 'descr' => 'Other'),
array('value' => 2, 'generic' => 3, 'graph' => 0, 'descr' => 'None'),
array('value' => 3, 'generic' => 0, 'graph' => 0, 'descr' => 'Normal'),
array('value' => 4, 'generic' => 2, 'graph' => 0, 'descr' => 'Bypass'),
array('value' => 5, 'generic' => 2, 'graph' => 0, 'descr' => 'Battery'),
array('value' => 6, 'generic' => 2, 'graph' => 0, 'descr' => 'Booster'),
array('value' => 7, 'generic' => 2, 'graph' => 0, 'descr' => 'Reducer'),
)

logmaster returns a diferente association of id and status.

Contributor

alangregory commented Oct 24, 2017

Looks like 70% works with rfc1628 , so i'm only adding aditional sensors. Is it possible to overide realtionship from some states ? Like:

array(
array('value' => 1, 'generic' => 3, 'graph' => 0, 'descr' => 'Other'),
array('value' => 2, 'generic' => 3, 'graph' => 0, 'descr' => 'None'),
array('value' => 3, 'generic' => 0, 'graph' => 0, 'descr' => 'Normal'),
array('value' => 4, 'generic' => 2, 'graph' => 0, 'descr' => 'Bypass'),
array('value' => 5, 'generic' => 2, 'graph' => 0, 'descr' => 'Battery'),
array('value' => 6, 'generic' => 2, 'graph' => 0, 'descr' => 'Booster'),
array('value' => 7, 'generic' => 2, 'graph' => 0, 'descr' => 'Reducer'),
)

logmaster returns a diferente association of id and status.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 24, 2017

Member

It's not possible right now. We probably should work out some way to make that happen though.

Member

laf commented Oct 24, 2017

It's not possible right now. We probably should work out some way to make that happen though.

@alangregory

This comment has been minimized.

Show comment
Hide comment
@alangregory

alangregory Oct 24, 2017

Contributor

Ok, added the state that matters.

Contributor

alangregory commented Oct 24, 2017

Ok, added the state that matters.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 24, 2017

The inspection completed: 2 new issues

scrutinizer-notifier commented Oct 24, 2017

The inspection completed: 2 new issues

@laf

laf approved these changes Oct 24, 2017

@laf laf merged commit 50413ff into librenms:master Oct 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@alangregory alangregory referenced this pull request Oct 26, 2017

Merged

logmaster Os updates #7553

1 of 1 task complete

@alangregory alangregory deleted the OpcaoTelecom:logmaster branch Apr 11, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.