New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eltek enexus #7552

Merged
merged 2 commits into from Nov 6, 2017

Conversation

Projects
None yet
5 participants
@barryodonovan
Contributor

barryodonovan commented Oct 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 26, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 26, 2017

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 26, 2017

Member

You might be able to use #7558 if/when it is merged.

Member

murrant commented Oct 26, 2017

You might be able to use #7558 if/when it is merged.

@laf

Some small changes needed + can you rename mibs/eltek/EltekEnexusPowersystem_branch10_V37.mib to mibs/eltek/SP2-MIB

Show outdated Hide outdated includes/polling/os/eltek.inc.php Outdated
Show outdated Hide outdated includes/polling/os/eltek.inc.php Outdated
Show outdated Hide outdated tests/snmpsim/eltek.snmprec Outdated
@laf

laf approved these changes Oct 27, 2017

@laf

Ok, last one from me.

eltek is the company, OS' shouldn't be named after the company, they should be named after the OS / Firmware. Does this have a name? If not, then the product family this covers should be used.

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Oct 31, 2017

Contributor

@laf @murrant
I'm quite happy to change it, it only covers a subset of the Eltek-Valere family.
Minicom is the model I have, eNexus is the product family, SP2 is the MIB, I'm not sure which is better? There is no obvious firmware name.

Perhaps, Eltek-eNexus? That's what I've called the branch for the PR as I think it is most accurate?

Contributor

barryodonovan commented Oct 31, 2017

@laf @murrant
I'm quite happy to change it, it only covers a subset of the Eltek-Valere family.
Minicom is the model I have, eNexus is the product family, SP2 is the MIB, I'm not sure which is better? There is no obvious firmware name.

Perhaps, Eltek-eNexus? That's what I've called the branch for the PR as I think it is most accurate?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 31, 2017

Member

I'd go for just enexus

Member

laf commented Oct 31, 2017

I'd go for just enexus

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Oct 31, 2017

Contributor
Contributor

barryodonovan commented Oct 31, 2017

@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Nov 1, 2017

Contributor

Back to failing on the pre-commit script again.

Can't see why, last time it was the cache invalidation issue but not now.

Contributor

barryodonovan commented Nov 1, 2017

Back to failing on the pre-commit script again.

Can't see why, last time it was the cache invalidation issue but not now.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 2, 2017

Member

Most likely because we had to remove the snmp_get ability in discovery, it's back in again now so just rebase and it should pass.

Member

laf commented Nov 2, 2017

Most likely because we had to remove the snmp_get ability in discovery, it's back in again now so just rebase and it should pass.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 4, 2017

Member

:( This has ended up with loads of commits we've already merged :(

Member

laf commented Nov 4, 2017

:( This has ended up with loads of commits we've already merged :(

barryodonovan
initial discovery
eltek-enexus discovery and polling

discovery and polling using yaml for subset of features

discovery and polling using yaml for subset of features

removed a few bits

removed some snmp_get() and renamed MIB

 removed header bar mini graph

added snmpget discovery to yaml

renamed os to enexus

undo rebase
@barryodonovan

This comment has been minimized.

Show comment
Hide comment
@barryodonovan

barryodonovan Nov 6, 2017

Contributor

Hopefully this rebase is a bit cleaner!

Contributor

barryodonovan commented Nov 6, 2017

Hopefully this rebase is a bit cleaner!

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 6, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 6, 2017

The inspection completed: No new issues

@laf laf merged commit 48b5647 into librenms:master Nov 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@barryodonovan barryodonovan referenced this pull request Feb 20, 2018

Closed

Eltek Valere Minipack #7526

5 of 5 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.