New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail isPingable() if fping fails, take 2 #7585

Merged
merged 3 commits into from Oct 31, 2017

Conversation

Projects
None yet
4 participants
@Zmegolaz
Member

Zmegolaz commented Oct 30, 2017

Another take on #7426.
If the command fping fails, the function isPingable() should fail too, for example for invalid hostnames.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Zmegolaz added some commits Oct 30, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 30, 2017

Member

I feel like it would be a bit cleaner to leave the return array as a single level array and either unset exitcode before updating the db or array_filter() the array for valid keys for the database.

Third option is to add exitcode field to the database, but I don't think that would be worth storing.

Member

murrant commented Oct 30, 2017

I feel like it would be a bit cleaner to leave the return array as a single level array and either unset exitcode before updating the db or array_filter() the array for valid keys for the database.

Third option is to add exitcode field to the database, but I don't think that would be worth storing.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 30, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 30, 2017

The inspection completed: No new issues

@laf

laf approved these changes Oct 30, 2017

@murrant murrant merged commit 297e5ae into librenms:master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Zmegolaz Zmegolaz deleted the Zmegolaz:fping-exitcode branch Oct 31, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.