New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Allow snmpget in os discovery yaml #7587

Merged
merged 2 commits into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Oct 30, 2017

Re-submit after release of: #7558, #7561, #7566
Minor change to trim quotes from snmpget...

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Show outdated Hide outdated includes/functions.php Outdated
@laf

We're still going to have issues with os cache being invalid if people update straight to this commit from any version prior to the one that invalidates the cache on update.

I'm not sure we can do much about that though so more just an fyi than anything else.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 30, 2017

Member

The cache invalidation should be run pretty early in daily.sh after the code update, but there is still a window that discovery could start in to have invalid cache.

Member

murrant commented Oct 30, 2017

The cache invalidation should be run pretty early in daily.sh after the code update, but there is still a window that discovery could start in to have invalid cache.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 30, 2017

Member

But the cache invalidation won't run until the next time daily.sh does so if someone updates from before that PR to this or later then the cache issue still persists.

Member

laf commented Oct 30, 2017

But the cache invalidation won't run until the next time daily.sh does so if someone updates from before that PR to this or later then the cache issue still persists.

Show outdated Hide outdated includes/functions.php Outdated

murrant added some commits Oct 30, 2017

feature: Allow snmpget in os discovery yaml
Re-submit after release
Remove extra trim in discovery and in snmp_get.
also trim() always returns a string, so is_string() check is a waste of cpu cycles.
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 2, 2017

Member

We'll merge this sometime tomorrow.

Member

murrant commented Nov 2, 2017

We'll merge this sometime tomorrow.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 2, 2017

The inspection completed: 3 new issues, 5 updated code elements

scrutinizer-notifier commented Nov 2, 2017

The inspection completed: 3 new issues, 5 updated code elements

@laf laf merged commit 0d07f85 into librenms:master Nov 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:discovery-yaml branch Nov 2, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.