New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show the neighbour tab if there are neighbors to show #7591

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Oct 31, 2017

Also, fix up the sql statements in this file. No reason to count entries if we only want to know if at least one entry exists.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: only show the neighbour tab if there are neighbors to show
Also, fix up the sql statements in this file.  No reason to count entries if we only want to know if at least one entry exists.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 31, 2017

The inspection completed: 20 new issues, 3 updated code elements

scrutinizer-notifier commented Oct 31, 2017

The inspection completed: 20 new issues, 3 updated code elements

@laf laf merged commit 6e3ea8b into librenms:master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Only show the neighbour tab if there are neighbors to show (libr…
…enms#7591)

Also, fix up the sql statements in this file.  No reason to count entries if we only want to know if at least one entry exists.

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request Nov 1, 2017

fix: Only show the neighbour tab if there are neighbors to show (libr…
…enms#7591)

Also, fix up the sql statements in this file.  No reason to count entries if we only want to know if at least one entry exists.

@murrant murrant deleted the murrant:neighbour-tab branch Nov 2, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.