New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: discovery.php -h all stops working after ping only device #7593

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@Zmegolaz
Member

Zmegolaz commented Oct 31, 2017

If a ping only device is discovered before any other device, the discovery_modules config variable was emptied for the rest of them.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@Zmegolaz Zmegolaz changed the title from Temporary array per device in discovery to Fix: Temporary modules array per device in discovery Oct 31, 2017

@murrant

I would prefer if snmp_disable, return at the beginning of this.

@murrant murrant changed the title from Fix: Temporary modules array per device in discovery to Fix: discovery.php -h all stops working after ping only device Oct 31, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Oct 31, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Oct 31, 2017

The inspection completed: No new issues

@murrant murrant merged commit e74b1c3 into librenms:master Oct 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Zmegolaz Zmegolaz deleted the Zmegolaz:discovery-module-ping branch Oct 31, 2017

murrant added a commit that referenced this pull request Nov 1, 2017

Fix: discovery.php -h all stops working after ping only device (#7593)
* Temporary array per device in discovery.

* Return at the beginning of discover_device() if snmp_disable.
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.