New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: update hwg-ste and add hwg-ste-plus support #7610

Merged
merged 2 commits into from Nov 4, 2017

Conversation

Projects
None yet
3 participants
@tomarch
Contributor

tomarch commented Nov 2, 2017

Update HWG-STE support:
-disable bulk
-disable discovery and poller that don't work (the poller time goes from 50s to 2sec now)
-remove bits over graph
-add temperature over graph
-update STE-MIB
-remove php file for temperature and sensors (replace by yaml)

Add HWG-STE-PLUS (Same as HWG-STE but with 2 Dry Contacts)
-use same definition as HWG-STE
-dry contact value (open or closed)
-dry contact alarm status (normal or alarm)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

tomarch added some commits Nov 2, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 2, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 2, 2017

Member

I'm assuming people lose the old data with this update?

Member

laf commented Nov 2, 2017

I'm assuming people lose the old data with this update?

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Nov 3, 2017

Contributor

I suppose nobody have data unless they have disable bulkwalk manually (this device doesn't support bulk).
How to not lose old data (except by create a new os) ?

Contributor

tomarch commented Nov 3, 2017

I suppose nobody have data unless they have disable bulkwalk manually (this device doesn't support bulk).
How to not lose old data (except by create a new os) ?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 3, 2017

Member

The only way to not lose old data would be to match up the indexes.

Are you 100% all of these devices don't work with bulkwalk or just some do some don't?

Member

laf commented Nov 3, 2017

The only way to not lose old data would be to match up the indexes.

Are you 100% all of these devices don't work with bulkwalk or just some do some don't?

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Nov 3, 2017

Contributor

Sure the hwg-ste-plus don't work with bulkwalk.
For the hwg-ste it's seem to be the same (as seen in #3606) and it's the same os.

Contributor

tomarch commented Nov 3, 2017

Sure the hwg-ste-plus don't work with bulkwalk.
For the hwg-ste it's seem to be the same (as seen in #3606) and it's the same os.

@laf laf merged commit 1009952 into librenms:master Nov 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.