New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: support Avtech RoomAlert 32E/W and RoomAlert 11E #7614

Merged
merged 3 commits into from Nov 4, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 2, 2017

Move other avtech sensors to yaml
This required more flexibility when checking pre-cached data

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #7530

murrant added some commits Nov 2, 2017

newdevice: support Avtech RoomAlert 32E/W
Move avtech discovery to yaml, took a bit of trickery
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 2, 2017

Member

Not able to use mibs for these?

how much have you been able to test backwards compatibility for existing yaml sensors?

Member

laf commented Nov 2, 2017

Not able to use mibs for these?

how much have you been able to test backwards compatibility for existing yaml sensors?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 3, 2017

Member

@laf no there are mibs for different devices, that have the same names, but different oids.

I did not want to add an os for each device. Also there are no tables anyway so it wouldn't be much different.

I took care to maintain the rrd name of the temperature sensors, but I think I couldn't make it match for the state sensors.

Member

murrant commented Nov 3, 2017

@laf no there are mibs for different devices, that have the same names, but different oids.

I did not want to add an os for each device. Also there are no tables anyway so it wouldn't be much different.

I took care to maintain the rrd name of the temperature sensors, but I think I couldn't make it match for the state sensors.

@murrant murrant changed the title from newdevice: support Avtech RoomAlert 32E/W to newdevice: support Avtech RoomAlert 32E/W and RoomAlert 11E Nov 3, 2017

Add support for RoomAlert 32E/W external and wish temp sensors
Add RoomAlert 11E support (just temp sensors)
Updated ROOMALERT32E-MIB
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 3, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Nov 3, 2017

The inspection completed: 2 updated code elements

@laf laf merged commit 3dba5cd into librenms:master Nov 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:avtech-ra32 branch Nov 21, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.