New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devices detected as ibmtl or generic #7618

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Nov 3, 2017

Guess at the sysObjectID, please report if you have devices that should be ibmtl and are no longer detected.
Add output of os in discovery.
Change the way we clear the os def cache during daily update remove it (it will be regenerated on next discovery run)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: devices detected as ibmtl
Guess at the sysObjectID, please report if you have devices that should be ibmtl and are no longer detected.
Add output of os in discovery.
@@ -5,6 +5,8 @@ icon: generic
over:
- { graph: device_bits, text: Traffic }
discovery:
- snmpget:
-
sysObjectId: .1.3.6.1.4.1.14851
@laf

laf Nov 3, 2017

Member

This comment has been minimized.

@murrant

murrant Nov 3, 2017

Member

Close enough :)

@murrant

murrant Nov 3, 2017

Member

Close enough :)

@murrant murrant changed the title from fix: devices detected as ibmtl to fix: devices detected as ibmtl or generic Nov 3, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 3, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Nov 3, 2017

The inspection completed: 2 updated code elements

@murrant murrant merged commit 54b476c into librenms:master Nov 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:ibmtl branch Nov 3, 2017

@joelsdc

This comment has been minimized.

Show comment
Hide comment
@joelsdc

joelsdc Nov 6, 2017

(edited)

I created a new issue, not sure if it is related:

#7654

joelsdc commented Nov 6, 2017

(edited)

I created a new issue, not sure if it is related:

#7654

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.