New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not add invalid Cisco senors seen in IOS 15.6(3)M1 #7629

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@Rosiak
Contributor

Rosiak commented Nov 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Cisco introduced invalid sensors into IOS 15.6(3)M1, this fix makes sure we do not add these sensors.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 15, 2017

Member

Does an empty description definitely mean bad sensor?

Member

laf commented Nov 15, 2017

Does an empty description definitely mean bad sensor?

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 15, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 15, 2017

The inspection completed: No new issues

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Nov 15, 2017

Contributor

@laf I won't say I'm 100% sure, but I've only seen it empty in this software version so far.

Contributor

Rosiak commented Nov 15, 2017

@laf I won't say I'm 100% sure, but I've only seen it empty in this software version so far.

@laf laf merged commit 37d005e into librenms:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.