Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Install Docs Update #7630

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Rosiak
Copy link
Member

@Rosiak Rosiak commented Nov 5, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


> Please note the following docs are new and may not be 100% complete, please provide feedback on your experience.
**Please note from January 10th 2018, the minimum supported PHP version will be 5.6.4** [More]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in all the other install docs as well as most likely people will skip straight to those. We also don't need to say from Jan the 10th here and just say, min supported version is 5.6.4 now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, much clearer if we just say the minimum version is 5.6.4 for newcomers.

@@ -1,15 +1,17 @@
source: Installation/Installing-LibreNMS.md
# Installing LibreNMS

We have some pre-built VirtualBox images you can use to get started:
##Images
We have some pre-built VirtualBox images you can use to get started. Please note that these images are pre-built for VirtualBox, hence they might not work with other hypervisors:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly just adding hence they might not work with other hypervisors without converting them:


[Ubuntu 16.04](http://docs.librenms.org/Installation/Ubuntu-image/)

[CentOS 7](http://docs.librenms.org/Installation/CentOS-image/)

If you want to install yourself then we have some new documentation which should make it easy.
##Manuel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manuel -> Manual

@@ -29,3 +31,5 @@ If the above are missing or incomplete then you can try our old docs below.
[Debian/Ubuntu Lighttpd](http://docs.librenms.org/Installation/Installation-Ubuntu-1404-Lighttpd/)

[Debian/Ubuntu Nginx](http://docs.librenms.org/Installation/Installation-Ubuntu-1404-Nginx/)

[More]: https://community.librenms.org/t/change-to-php-minimum-version-5-6/2542
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly unnecessary if we just are posting the minimum version as 5.6.4. We'll advertise this link on social media.

@Rosiak
Copy link
Member Author

Rosiak commented Nov 14, 2017

Some changes:

  • Changed the wording based on your comments.
  • Included the "warning" in each installation document.
  • Removed references and information around Centos 7 information from the Centos 6 document, as we already have that documentation separately.
  • Aligned the intro wording across each document.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@laf laf merged commit ec2256c into librenms:master Nov 15, 2017
@lock
Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants