Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding manage_bills.php script to scripts directory #7633
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Thanks for this.
I've made a few changes with a git diff if you want to take a look: https://p.libren.ms/view/397b1866
Any reason you don't check hostname rather than sysName?
Can you reverse the default of
Nice, thank you!
Mainly as the set of devices I'm working on have a
Sure - should I change the name to flush, so it becomes a bit more obvious?
Hostname would be better as it's unique, sysName isn't always depending on the devices :(
You could have two flags so people can pass either hostname or sysname?
Flush seems good.
Code review was much appreciated, thank you for taking the time to do this.
I changed the flow logic around a bit for detecting -h/-s, so that it'll print warnings, then help.
Not setting -i will also cause the script to bail out.
I also renamed the create_bill function to add_ports_to_bill (So I would not clobber the add_ports functioning already existing).
Cheers + thanks against for assisting.