New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extra fping checks in validation #7651

Merged
merged 5 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 6, 2017

Don't check suid or getcap if we can execute fping (as librenms or webserver user)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: Extra fping checks in validation
Don't check suid or getcap if we can execute fping (as librenms or webserver user)

@murrant murrant referenced this pull request Nov 6, 2017

Closed

fix suid should be warning in webui #7649

1 of 1 task complete
@laf

laf approved these changes Nov 7, 2017

murrant added some commits Nov 7, 2017

Use locate_binary() so we match production code (it is also better)
Don't cripple capabilities check, prefer that over suid.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 7, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Nov 7, 2017

The inspection completed: 1 updated code elements

@murrant murrant removed the Needs Testing label Nov 7, 2017

@murrant murrant merged commit 52784ed into librenms:master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fping-extra-checks branch Nov 7, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.