New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Updated Checkpoint Gaia detection and added storage #7656

Merged
merged 5 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Nov 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7391

@laf laf added the Device 🖥 label Nov 6, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 7, 2017

Member

I've updated the index column in storage to match sensors. Not all devices return a single int for indexes :(

Member

laf commented Nov 7, 2017

I've updated the index column in storage to match sensors. Not all devices return a single int for indexes :(

Show outdated Hide outdated includes/definitions/gaia.yaml Outdated
Show outdated Hide outdated includes/definitions/gaia.yaml Outdated
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 15, 2017

Member

@laf

discovery:
    - sysObjectId:
        - .1.3.6.1.4.1.2620.1.6.123.1
    -
      sysObjectId: .1.3.6.1.4.1.8072.3.2.10
      snmpget:
        oid: CHECKPOINT-MIB::osName.0
        mib_dir: checkpoint
        op: 'contains'
        value: Gaia

Here's what happens for gaia_1430.snmprec:

  1. Check sysObjectId against .1.3.6.1.4.1.2620.1.6.123.1 fail
  2. Check sysObjectId against .1.3.6.1.4.1.8072.3.2.10 success
  3. Check snmpget success

The first level in the array is OR. The second level is AND. The third level is OR.

Member

murrant commented Nov 15, 2017

@laf

discovery:
    - sysObjectId:
        - .1.3.6.1.4.1.2620.1.6.123.1
    -
      sysObjectId: .1.3.6.1.4.1.8072.3.2.10
      snmpget:
        oid: CHECKPOINT-MIB::osName.0
        mib_dir: checkpoint
        op: 'contains'
        value: Gaia

Here's what happens for gaia_1430.snmprec:

  1. Check sysObjectId against .1.3.6.1.4.1.2620.1.6.123.1 fail
  2. Check sysObjectId against .1.3.6.1.4.1.8072.3.2.10 success
  3. Check snmpget success

The first level in the array is OR. The second level is AND. The third level is OR.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 15, 2017

Member

Updated and pushed - cheers.

Member

laf commented Nov 15, 2017

Updated and pushed - cheers.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 22, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 22, 2017

The inspection completed: No new issues

@murrant murrant merged commit b45302b into librenms:master Nov 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-7391 branch Nov 23, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.