New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better validation on callback url for Pagerduty integration #7658

merged 1 commit into from Nov 7, 2017


None yet
3 participants
Copy link

laf commented Nov 6, 2017


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

If the callback url wasn't a full url then the Pagerduty integration would 404 on the PD side.

@laf laf added Bug 🐞 WebUI labels Nov 6, 2017


This comment has been minimized.

Copy link

scrutinizer-notifier commented Nov 6, 2017

The inspection completed: No new issues

@murrant murrant merged commit f84844f into librenms:master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
license/cla Contributor License Agreement is signed.

@laf laf deleted the laf:fix/pagerduty-integration branch Nov 7, 2017


This comment has been minimized.

Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.