New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch to using discovery-wrapper.py by default #7661

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Nov 7, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Seems sensible to run like this now. Won't effect new installs.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 7, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 7, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 7, 2017

Member

Great, but I think the default thread count should be 2 or 4 instead of 1.
Also, maybe moving from minute 33 to minute 32.

Member

murrant commented Nov 7, 2017

Great, but I think the default thread count should be 2 or 4 instead of 1.
Also, maybe moving from minute 33 to minute 32.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 7, 2017

Member

1 means it’s a direct replacement for the php version and should guarantee that we don’t overload installs, changing it to another value won’t guarantee that :(

Member

laf commented Nov 7, 2017

1 means it’s a direct replacement for the php version and should guarantee that we don’t overload installs, changing it to another value won’t guarantee that :(

@Zmegolaz

This comment has been minimized.

Show comment
Hide comment
@Zmegolaz

Zmegolaz Nov 9, 2017

Member

I've been running this with 4 threads for a day now and tried adding/removing devices, seems to work.

But this will only affect new installs, won't it? In that case nothing will break for existing users if it's set to more threads.

Member

Zmegolaz commented Nov 9, 2017

I've been running this with 4 threads for a day now and tried adding/removing devices, seems to work.

But this will only affect new installs, won't it? In that case nothing will break for existing users if it's set to more threads.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 9, 2017

Member

But this will only affect new installs, won't it? In that case nothing will break for existing users if it's set to more threads.

Correct but we've had no feedback so imho, I'd prefer to start out with how it is now and as people start reporting positive changes then we start increasing the limit.

I actually plan to remove the thread argument and allow people to just set in config.

Member

laf commented Nov 9, 2017

But this will only affect new installs, won't it? In that case nothing will break for existing users if it's set to more threads.

Correct but we've had no feedback so imho, I'd prefer to start out with how it is now and as people start reporting positive changes then we start increasing the limit.

I actually plan to remove the thread argument and allow people to just set in config.

@murrant murrant merged commit a14539a into librenms:master Nov 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:refactor/switch-to-discovery-wrapper branch Nov 9, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.