New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: initial detection for Arris Cable Modem devices #7677

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@@ -0,0 +1,10 @@
os: arris-cm

This comment has been minimized.

@laf

laf Nov 8, 2017

Member

Definitely the right os name to use? would arris-docsis not fit better? Do they have a name for the firmware?

@laf

laf Nov 8, 2017

Member

Definitely the right os name to use? would arris-docsis not fit better? Do they have a name for the firmware?

This comment has been minimized.

@murrant

murrant Nov 8, 2017

Member

I started out as arris-docsis, then I saw the name of their MIB was arris-cm... Perhaps I should include the mibs even though they are not used?

@murrant

murrant Nov 8, 2017

Member

I started out as arris-docsis, then I saw the name of their MIB was arris-cm... Perhaps I should include the mibs even though they are not used?

This comment has been minimized.

@laf

laf Nov 8, 2017

Member

Up to you, I used to tell people not to when I could see they weren't used but they can be useful later on.

Let me know what you decide or merge when you feel it's ready.

@laf

laf Nov 8, 2017

Member

Up to you, I used to tell people not to when I could see they weren't used but they can be useful later on.

Let me know what you decide or merge when you feel it's ready.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 10, 2017

The inspection completed: No new issues

@murrant murrant merged commit 4658289 into librenms:master Nov 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:arris-docsis branch Nov 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.