Callback system for stats #768

Merged
merged 10 commits into from Apr 12, 2015

Projects

None yet

3 participants

@laf
Member
laf commented Apr 9, 2015

Putting here ready for merging. Code should be good but suggestions are welcome.

@laf
Member
laf commented Apr 9, 2015

ps. don't merge this until we have a vm online to collect the stats. at which point i need to update the submission urls

@f0o
Member
f0o commented Apr 10, 2015

I'm not 100% happy with uniqid as uuid. I'd prefer seeing RFC 4122, UUID version 4.

I can provide a single function to generate UUIDv4 if needed

@laf
Member
laf commented Apr 10, 2015

Go for it.

Out of interest what's up with uuid from php?

@f0o
Member
f0o commented Apr 10, 2015

@paulgear that function fits good. Important is the use of openssl's entropy source over mt_rand, rand, uniqid, ...

@f0o
Member
f0o commented Apr 10, 2015

@laf the docs for debian have a wrong patch. The PEAR package is not php5-pear, it's php-pear https://packages.debian.org/wheezy/php-pear :)

@laf
Member
laf commented Apr 10, 2015

ok, all good to go.

urls updated to point to https://stats.librenms.org (which has been updated with the suggested changes).

data cleared out so no stats in at the moment (I have a large install using it so when daily.sh runs it will create the first lot).

no logging on the web server so we should be good to go.

@paulgear
Member

+1 from me - any other comments?

@laf
Member
laf commented Apr 11, 2015

Nothing from me - I updated the uuid to use that function from stackoverflow. Credits are in comments within the function for it.

I do want to get the graphs visually looking better but for now it's a starting point.

@f0o f0o merged commit 7d478c0 into librenms:master Apr 12, 2015

1 check passed

Scrutinizer 6 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment