New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Health/sensor view for specific device/ports/port #7684

Merged
merged 4 commits into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@bergroth
Contributor

bergroth commented Nov 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 8, 2017

Member

What devices does this work for?

Member

laf commented Nov 8, 2017

What devices does this work for?

@bergroth

This comment has been minimized.

Show comment
Hide comment
@bergroth

bergroth Nov 8, 2017

Contributor
Contributor

bergroth commented Nov 8, 2017

Show outdated Hide outdated html/pages/device/port.inc.php Outdated
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 8, 2017

Member

Thanks, this needs an additional column to be checked then. See my inline comment.

Member

laf commented Nov 8, 2017

Thanks, this needs an additional column to be checked then. See my inline comment.

@bergroth

This comment has been minimized.

Show comment
Hide comment
@bergroth

bergroth Nov 8, 2017

Contributor
Contributor

bergroth commented Nov 8, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 8, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 8, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 9, 2017

Member

Hmm, this doesn't work on my cisco device. I don't think these fields are consistently set accross all our health sensors:

sensor_id sensor_descr entPhysicalIndex entPhysicalIndex_measured entity_link_type entity_link_index
9543 Gi2/0/25 Transmit Power 2041 port 10625
9544 Gi2/0/25 Receive Power 2042 port 10625
9548 Gi2/0/26 Transmit Power 2047 port 10626
9549 Gi2/0/26 Receive Power 2048 port 10626
Member

murrant commented Nov 9, 2017

Hmm, this doesn't work on my cisco device. I don't think these fields are consistently set accross all our health sensors:

sensor_id sensor_descr entPhysicalIndex entPhysicalIndex_measured entity_link_type entity_link_index
9543 Gi2/0/25 Transmit Power 2041 port 10625
9544 Gi2/0/25 Receive Power 2042 port 10625
9548 Gi2/0/26 Transmit Power 2047 port 10626
9549 Gi2/0/26 Receive Power 2048 port 10626
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 9, 2017

Member

I added those two columns in not realising we had some support, just needs updating to use the old columns

Member

laf commented Nov 9, 2017

I added those two columns in not realising we had some support, just needs updating to use the old columns

@murrant murrant merged commit a16c142 into librenms:master Nov 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.