New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number comparisons in alerts and device groups #7695

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 9, 2017

Remove quotes so if the field we are comparing against is a string type, we still do a number comparison.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: number comparisons in alerts and device groups
Remove quotes so if the field we are comparing against is a string type, we still do a number comparison.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 9, 2017

The inspection completed: 8 new issues, 20 updated code elements

scrutinizer-notifier commented Nov 9, 2017

The inspection completed: 8 new issues, 20 updated code elements

@laf laf merged commit 8b3bd57 into librenms:master Nov 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-alert-numbers branch Nov 9, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.