New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Expose pollers link to show total poll time for all devices per poller #7699

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Nov 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the WebUI label Nov 9, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 9, 2017

Member

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

Member

murrant commented Nov 9, 2017

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 12, 2017

Member

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Sorry I don't know what you mean here.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

Up to you but an additional sql query to show the link, worth it?

Member

laf commented Nov 12, 2017

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Sorry I don't know what you mean here.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

Up to you but an additional sql query to show the link, worth it?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 13, 2017

Member

Creating poller groups is only relevant for people using distributed polling.

The sql query would be very quick, counting the rows on a table with probably single digit entries.

So options:

  1. Hide poller groups tab with check on the distributed polling option
  2. Change checks from option to db check. Add extra warning about creating poller groups.
Member

murrant commented Nov 13, 2017

Creating poller groups is only relevant for people using distributed polling.

The sql query would be very quick, counting the rows on a table with probably single digit entries.

So options:

  1. Hide poller groups tab with check on the distributed polling option
  2. Change checks from option to db check. Add extra warning about creating poller groups.
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 13, 2017

Member

After some looking at the poller-wrapper problem, I vote for 1

Member

murrant commented Nov 13, 2017

After some looking at the poller-wrapper problem, I vote for 1

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 13, 2017

The inspection completed: No new issues

@murrant murrant merged commit 4e59dd4 into librenms:master Nov 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:webui/add-pollers-link branch Nov 13, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.