Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: Only update sensor/bgp tables when values are changed #7707
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
This stops updates to the sensors table until the values have actually changed. For devices that have a lot of sensors (one debug output I've just looked at had probably 1000 updates against it. This will cut that down substantially.
@shimamizu is kindly going to test this in real life.
K so earlier today before that patch 7707 we had this for mysql:
and now after 7707
that did lower the updates it looks like
I'm going to enable Enable selected port polling? for this test device next and see if it goes even lower
Test device is an Arista 7508 for reference
Wrong before comparison for the time it took on the slow server:
But still 220s before for updates -> 141s after for updates (about 400 less updates) with this change.
Also testing now with selected port polling next.
Yes you won't see much of a difference using selected port polling with or not with the patch as we already filter out updates that aren't needed.
So to be clear in your scenario @shimamizu:
Local poller in Isreal
Local poller in US