New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do basic input validation for screen width and height #7713

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
5 participants
@davidediger
Contributor

davidediger commented Nov 12, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Nov 12, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Nov 12, 2017

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 12, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 12, 2017

The inspection completed: No new issues

@@ -3,8 +3,10 @@
session_start();
if (isset($_REQUEST['width'], $_REQUEST['height'])) {
$_SESSION['screen_width'] = $_REQUEST['width'];
$_SESSION['screen_height'] = $_REQUEST['height'];
if (is_numeric($_REQUEST['height']) && is_numeric($_REQUEST['width'])) {

This comment has been minimized.

@Zmegolaz

Zmegolaz Nov 13, 2017

Member

You could put this in the same if statement as the isset() check.

@Zmegolaz

Zmegolaz Nov 13, 2017

Member

You could put this in the same if statement as the isset() check.

@murrant murrant merged commit 3c94ce7 into librenms:master Nov 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.