New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: allow deletion of dead poller nodes #7721

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Nov 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@doppiscantsleep

This comment has been minimized.

Show comment
Hide comment
@doppiscantsleep

doppiscantsleep Nov 14, 2017

Worked for me but do I need to do anything about this validation warning?

Your local git contains modified files, this could prevent automatic updates.
[FIX] You can fix this with ./scripts/github-remove
Modified Files:
html/pages/pollers/pollers.inc.php

I'm pretty new to this, sorry.

doppiscantsleep commented Nov 14, 2017

Worked for me but do I need to do anything about this validation warning?

Your local git contains modified files, this could prevent automatic updates.
[FIX] You can fix this with ./scripts/github-remove
Modified Files:
html/pages/pollers/pollers.inc.php

I'm pretty new to this, sorry.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 14, 2017

Member

@doppiscantsleep Thanks for testing!

You can remove the modifications with ./scripts/github-remove and wait for this to be merged.

Member

murrant commented Nov 14, 2017

@doppiscantsleep Thanks for testing!

You can remove the modifications with ./scripts/github-remove and wait for this to be merged.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 16, 2017

Member

Just one comment from me.

Member

laf commented Nov 16, 2017

Just one comment from me.

@shimamizu

This comment has been minimized.

Show comment
Hide comment
@shimamizu

shimamizu Nov 20, 2017

I wanted to add this but you're already working on it, been having to remove old PoC pollers from MySQL haha, a webgui ability to remove them would be great!

shimamizu commented Nov 20, 2017

I wanted to add this but you're already working on it, been having to remove old PoC pollers from MySQL haha, a webgui ability to remove them would be great!

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 22, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 22, 2017

The inspection completed: No new issues

@laf laf merged commit ea684c3 into librenms:master Nov 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:poller-delete branch Nov 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.