New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poller-wrapper.py keeps running when a poller takes too long #7722

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 13, 2017

name space the memcache variables for each polling interval based on the rrd.step value.
Make poller-wrapper.py respect the rrd.step setting

attempt to fix #7546

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: poller-wrapper.py keeps running when a poller takes too log
name space the memcache variables for each polling interval based on the rrd.step value.
Make poller-wrapper.py respect the rrd.step setting

@murrant murrant changed the title from fix: poller-wrapper.py keeps running when a poller takes too log to fix: poller-wrapper.py keeps running when a poller takes too long Nov 13, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 13, 2017

The inspection completed: No new issues

@laf

laf approved these changes Nov 19, 2017

LGTM.

Tested on a single poller setup to be a distributed setup.

@laf laf merged commit a56267e into librenms:master Nov 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:poller-wrapper-ns branch Nov 21, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.