New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert to two gets for sysDescr and sysObjectID #7741

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@murrant
Copy link
Member

murrant commented Nov 15, 2017

fixes: #7624

Some devices don't like asking for them in one get for some reason.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: revert to two gets for sysDescr and sysObjectID
Some devices don't like asking for them in one get for some reason.
@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Nov 15, 2017

The inspection completed: 1 updated code elements

@Rosiak Rosiak merged commit e6ba1ee into librenms:master Nov 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:two_gets_getHostOS branch Nov 15, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.