New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty group query #7760

Merged
merged 2 commits into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Nov 15, 2017

fix: empty device group query
Optimize it a bit to use the relationship.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 17, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 17, 2017

The inspection completed: No new issues

@laf laf merged commit 1cc0e7c into librenms:master Nov 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 19, 2017

Member

Out of interest - what does this actually fix?

Member

laf commented Nov 19, 2017

Out of interest - what does this actually fix?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 20, 2017

Member

@laf if there was a group with no devices, it tried an invalid sql query, the webui still displayed no devices.

Had a user ask about it on Discord, figured it was worth a quick fix, then found a better fix.

Bad SQL: https://pastebin.com/46VU19G9

Member

murrant commented Nov 20, 2017

@laf if there was a group with no devices, it tried an invalid sql query, the webui still displayed no devices.

Had a user ask about it on Discord, figured it was worth a quick fix, then found a better fix.

Bad SQL: https://pastebin.com/46VU19G9

@murrant murrant deleted the murrant:fix-empty-group-query branch Nov 20, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.