New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct entity columns for sensors #7775

Merged
merged 3 commits into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Nov 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Shouldn't have created these two columns in the first place.

This fixes that, updates the config macro, updates the existing alert rules, updates the sensors tables and then drops the old columns.

Only port was used in this regards so these queries are safe and we don't lose any other data.

@asteen-nexcess

This comment has been minimized.

Show comment
Hide comment
@asteen-nexcess

asteen-nexcess Nov 21, 2017

Contributor

@laf Looks good! Had to delete/re-add the alert rules for sensor under/over limit with linked port in order for it to alert properly, but is working as expected. Thanks again for the help.

Contributor

asteen-nexcess commented Nov 21, 2017

@laf Looks good! Had to delete/re-add the alert rules for sensor under/over limit with linked port in order for it to alert properly, but is working as expected. Thanks again for the help.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 22, 2017

Member

./daily.sh regenerates alert rules, so that should make the alert rules update right away.

Member

murrant commented Nov 22, 2017

./daily.sh regenerates alert rules, so that should make the alert rules update right away.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 22, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 22, 2017

The inspection completed: No new issues

@murrant murrant merged commit ccbe3ea into librenms:master Nov 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-7753 branch Nov 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.