New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow discovery to check if devices are down before skipping #7780

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 22, 2017

We could also exclude snmp_disable devices from SQL query, worthwhile?

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: allow discovery to check if devices are down before skipping
We could also exclude snmp_disable devices from SQL query, worthwhile?
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 22, 2017

Member

We could also exclude snmp_disable devices from SQL query, worthwhile?

Seems worthwhile yes.

Member

laf commented Nov 22, 2017

We could also exclude snmp_disable devices from SQL query, worthwhile?

Seems worthwhile yes.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 23, 2017

The inspection completed: No new issues

@laf laf merged commit 9113f81 into librenms:master Nov 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:disc-down branch Nov 23, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.