New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor changes and fixes to Alert Rules #7789

Merged
merged 3 commits into from Nov 24, 2017

Conversation

Projects
None yet
4 participants
@kkrumm1
Member

kkrumm1 commented Nov 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

Couple of things, main one is switch - to + both do the same so we should stick with a consistent standard which I think is - for most of our docs.

Show outdated Hide outdated doc/Alerting/Rules.md Outdated
Show outdated Hide outdated doc/Alerting/Rules.md Outdated

kkrumm1 and others added some commits Nov 24, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 24, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 24, 2017

The inspection completed: No new issues

@laf

laf approved these changes Nov 24, 2017

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Nov 24, 2017

Member

good to go?

Member

kkrumm1 commented Nov 24, 2017

good to go?

@laf laf merged commit 4120bbc into master Nov 24, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the kkrumm1-patch-1 branch Nov 24, 2017

laf added a commit that referenced this pull request Nov 26, 2017

docs: Minor changes and fixes to Alert Rules (#7789)
* docs: minor changes and fixes to Alert Rules

* Update Rules.md

* Update Rules.md
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.