New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: syslog table refresh #7796

Merged
merged 3 commits into from Dec 24, 2017

Conversation

Projects
None yet
5 participants
@crcro
Contributor

crcro commented Nov 26, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

webui unification, in progress, started from @Rosiak PR #7628 and @laf suggestion.
notes: uses css class from PR #7765

dashboard
before:
screen shot 2017-11-26 at 3 15 20 am

after:
screen shot 2017-11-26 at 4 39 27 am

page
before:
screen shot 2017-11-25 at 10 53 51 pm

after:
screen shot 2017-11-26 at 4 39 37 am

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Nov 26, 2017

The inspection completed: 1 updated code elements

@laf

This comment has been minimized.

Member

laf commented Nov 26, 2017

Thanks @crcro

Are you doing the devices page and alerts page? If they were all done then it would look standard and I'd say we should merge at that stage.

@crcro

This comment has been minimized.

Contributor

crcro commented Nov 26, 2017

alerts are already done in another PR, i will do everything else also. next is graylog integration tables (after graylog timezone feature)

@Rosiak

This comment has been minimized.

Contributor

Rosiak commented Nov 27, 2017

Awesome job @crcro, really happy you are doing this!

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Nov 27, 2017

@kkrumm1 kkrumm1 added the WebUI label Nov 29, 2017

@laf laf referenced this pull request Nov 30, 2017

Closed

Table updates tracking #7831

9 of 9 tasks complete

@laf laf merged commit 7171132 into librenms:master Dec 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@crcro crcro deleted the crcro:webui-syslog-refresh branch Dec 24, 2017

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.