New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UPS time remaining in Mikrotik RouterOs #7803

Merged
merged 3 commits into from Nov 27, 2017

Conversation

Projects
None yet
4 participants
@erotel
Contributor

erotel commented Nov 27, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Test in mikrotik and UPS Eaton Ellipse ECO
Before
mikrotik ups old

After
mikrotik ups new

In device

mikrotik ups

erotel and others added some commits Nov 27, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 27, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 27, 2017

Member

I love that UPS-MIB::upsEstimatedMinutesRemaining is in seconds. Perfect :)

Member

murrant commented Nov 27, 2017

I love that UPS-MIB::upsEstimatedMinutesRemaining is in seconds. Perfect :)

@laf laf added the Bug 🐞 label Nov 27, 2017

@laf laf merged commit 6b42413 into librenms:master Nov 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.