New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: devices table refresh #7809

Merged
merged 6 commits into from Dec 24, 2017

Conversation

Projects
None yet
5 participants
@crcro
Contributor

crcro commented Nov 27, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

webui unification, in progress, started from @Rosiak PR #7628 and @laf suggestion.
notes: uses css class and js function from PR #7765

before:
screen shot 2017-11-28 at 12 51 08 am

after:
screen shot 2017-11-28 at 12 50 18 am

crcro added some commits Nov 27, 2017

@kkrumm1 kkrumm1 added the WebUI label Nov 29, 2017

@laf laf referenced this pull request Nov 30, 2017

Closed

Table updates tracking #7831

9 of 9 tasks complete
@murrant

This comment has been minimized.

Member

murrant commented Dec 4, 2017

You also disabled the links to the graphs view here. I don't think there is another way to get to that view.

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 4, 2017

@murrant ... it was there but not in the screen capture, nonetheless i've updated the layout atm, more compact:

screen shot 2017-12-05 at 12 45 52 am

@laf

This comment has been minimized.

Member

laf commented Dec 7, 2017

The layout was a bit 'rubbish' before because of what we tried to fit on. That doesn't work quite so well now:

image

Have to say though, overall it looks a lot cleaner. Something needs to be done about the up / down / icmp / ping status column. That doesn't look nice now. I'm not sure what to suggest other than dropping the up / down and only having it say if it's icmp or ping (i.e if it is down) or wrap the text in something that makes it look a little slicker.

@murrant

This comment has been minimized.

Member

murrant commented Dec 10, 2017

Maybe putting up/down in a label like it was before (but not as big)

crcro added some commits Dec 10, 2017

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 10, 2017

The inspection completed: No new issues

@laf laf merged commit 7a0f8c0 into librenms:master Dec 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@crcro crcro deleted the crcro:webui-devices-refresh branch Dec 24, 2017

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.