New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Generic alerts for state sensors #7812

Merged
merged 5 commits into from Dec 2, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Nov 28, 2017

A bit of a hack, but gets the job done. Perhaps someone can refactor the ResolveGlues() function sometime to make it better.

Might need to audit state generics a bit, but that can be done over time.

Pending feedback and testing:

  • Docs
  • Collection rules (default rules?)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

feature: Generic alerts for state sensors
A bit of a hack, but gets the job done. Perhaps someone can refactor the ResolveGlues() function sometime to make it better.
@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Nov 28, 2017

Member

@murrant how would alert rule look like for this?

Member

kkrumm1 commented Nov 28, 2017

@murrant how would alert rule look like for this?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Nov 29, 2017

Member

%macros.state_sensor_critical = 1 will alert for any state sensor where the generic value for the current value is 2 (critical). If you want you can narrow it down to certain sensors... might be a good test.

Member

murrant commented Nov 29, 2017

%macros.state_sensor_critical = 1 will alert for any state sensor where the generic value for the current value is 2 (critical). If you want you can narrow it down to certain sensors... might be a good test.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 30, 2017

Member

Testing overnight, see if alerts are still generated then will merge tomorrow.

Member

laf commented Nov 30, 2017

Testing overnight, see if alerts are still generated then will merge tomorrow.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 2, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Dec 2, 2017

The inspection completed: 1 updated code elements

@laf laf merged commit 5405498 into librenms:master Dec 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:state-sensor-generic-alerts branch Dec 6, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.