New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: ports table refresh #7827

Merged
merged 8 commits into from Dec 24, 2017

Conversation

Projects
None yet
5 participants
@crcro
Copy link
Contributor

crcro commented Nov 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

webui unification, in progress, started from @Rosiak PR #7628 and @laf suggestion.

ports page
before:
screen shot 2017-11-29 at 3 45 03 am

after:
screen shot 2017-11-29 at 3 43 57 am

@crcro crcro referenced this pull request Nov 30, 2017

Closed

webui: ports table refresh #7817

1 of 1 task complete

@kkrumm1 kkrumm1 added the WebUI label Nov 30, 2017

@crcro

This comment has been minimized.

Copy link
Contributor Author

crcro commented Nov 30, 2017

deleted ports reworks
before:
screen shot 2017-11-30 at 5 37 35 pm

after:
screen shot 2017-11-30 at 6 24 00 pm

@laf laf referenced this pull request Nov 30, 2017

Closed

Table updates tracking #7831

9 of 9 tasks complete
@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 7, 2017

The deleted ports doesn't have a purge all anymore.

The search bar is mis-aligned quite a bit as well on both the deleted and ports page:

image

I'd have thought that the status indicator that's been re-worked on all the other PRs would have made it here as well.

@kkrumm1

This comment has been minimized.

Copy link
Member

kkrumm1 commented Dec 9, 2017

Worked for me. Looking good.

@crcro

This comment has been minimized.

Copy link
Contributor Author

crcro commented Dec 9, 2017

@laf ... added some limits on name displays to limit the options bar from overflowing, added a port status indicator (please ignore the style, it will match with others if all PR will be merged):

screen shot 2017-12-09 at 6 17 40 pm

@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 9, 2017

The searchbar still doesn't work for me:

image

No purge all for deleted ports page.

@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 10, 2017

I can see the the purge all link now but it doesn't do anything, maybe the === is too strict for the check?

I know I'm being petty about the search section but it still doesn't line up for me:

image

@crcro

This comment has been minimized.

Copy link
Contributor Author

crcro commented Dec 10, 2017

@laf ... what is your display resolution?

@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 10, 2017

1680x1050.

image

That should be in it's own column.

@crcro

This comment has been minimized.

Copy link
Contributor Author

crcro commented Dec 10, 2017

it should be right after options bar but your option bar has a larger width than mine, i’ll try to make some other tweaks

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Dec 11, 2017

Way out of scope for this PR, maybe when we switch out bootgrid...
I saw a table where you click an icon in the header of filterable columns to filter that column. Worked decently and took up very little space. (icon changed to show the column is filtered)

@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 11, 2017

it should be right after options bar but your option bar has a larger width than mine, i’ll try to make some other tweaks

If you split the into two columns though then that fixes it. That's how the existing ones were done.

@crcro crcro force-pushed the crcro:webui-ports-table branch from 6373edd to 1e7caa6 Dec 22, 2017

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Dec 22, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Copy link
Member

laf commented Dec 22, 2017

Thanks for the update @crcro. I think that's me done for requests now so I'm happy to merge all of these.

@librenms/reviewers anyone else got any more thoughts?

@crcro

This comment has been minimized.

Copy link
Contributor Author

crcro commented Dec 22, 2017

@laf ... my pleasure, sorry for the delay ... crazy days

@laf laf merged commit 3f0ad03 into librenms:master Dec 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@crcro crcro deleted the crcro:webui-ports-table branch Dec 24, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.