New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: save application metrics to db for alerting #7828

Merged
merged 3 commits into from Dec 1, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 30, 2017

However, alerting will not work because ResolveGlues() is broken.
Can add workaround after state_translations alerting is merged

Does not update all applications yet, not sure if that should be done here or in another PR. Most are simple, some are complex.

Introduces two handy functions dbDeleteOrphans() and array_by_column(). Will replace those in other locations after this is merged or separate them out if this is not merged.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Nov 30, 2017

feature: save application metrics to db for alerting
However, alerting will not work because ResolveGlues() is broken.
Can add workaround after state_translations alerting is merged

Does not update all applications yet, not sure if that should be done here or in another PR.

Introduces two handy functions dbDeleteOrphans() and array_by_column().  Will replace those in other locations after this is merged or separate them out if this is not merged.
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Nov 30, 2017

Member

Missing the schema file?

I can't help but feel we're wasting time with this :(

Member

laf commented Nov 30, 2017

Missing the schema file?

I can't help but feel we're wasting time with this :(

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 1, 2017

Member

Yeah, forgot schema :(

Yeah, I dunno, but we don't have a good alternative.

Member

murrant commented Dec 1, 2017

Yeah, forgot schema :(

Yeah, I dunno, but we don't have a good alternative.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 1, 2017

The inspection completed: 3 updated code elements

scrutinizer-notifier commented Dec 1, 2017

The inspection completed: 3 updated code elements

@laf laf added Feature Schema labels Dec 1, 2017

@laf laf merged commit 4a03e78 into librenms:master Dec 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:application-metrics branch Dec 1, 2017

@slashdoom slashdoom referenced this pull request Jan 2, 2018

Merged

refactoring: freeradius app metrics #8002

1 of 1 task complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.