New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed get_all_ports() for api not returning ports on admin tokens #7829

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Nov 30, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added API Bug 🐞 labels Nov 30, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 30, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Nov 30, 2017

The inspection completed: No new issues

@laf laf merged commit 5871ee1 into librenms:master Nov 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:api/fix-get-all-ports branch Nov 30, 2017

@BradHooper

This comment has been minimized.

Show comment
Hide comment
@BradHooper

BradHooper Dec 1, 2017

This did the trick @laf
Thanks

BradHooper commented Dec 1, 2017

This did the trick @laf
Thanks

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.