New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: health pages refresh #7834

Merged
merged 8 commits into from Dec 24, 2017

Conversation

Projects
None yet
6 participants
@crcro
Contributor

crcro commented Dec 1, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

tried to give the health pages consistent look.

before:
screen shot 2017-12-01 at 5 12 41 am

after:
screen shot 2017-12-01 at 5 11 58 am

@laf laf referenced this pull request Dec 1, 2017

Closed

Table updates tracking #7831

9 of 9 tasks complete
@breeman1

This comment has been minimized.

breeman1 commented Dec 1, 2017

Hi @crcro, Shouldn't the title name called "Used" be aligned with the actual bar graphs. Looks to be offset to the left.

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 1, 2017

@breeman1 ... this should be better?

screen shot 2017-12-01 at 4 02 40 pm

@kkrumm1 kkrumm1 added the WebUI label Dec 1, 2017

@murrant

This comment has been minimized.

Member

murrant commented Dec 1, 2017

@crcro you also lost the navigation here.

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 1, 2017

@murrant ... didn't loose it, removed it intentionally, same for wireless

@laf

This comment has been minimized.

Member

laf commented Dec 2, 2017

didn't loose it, removed it intentionally, same for wireless

Any reason why, that's handy set of links to move between the health sensors?

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 4, 2017

@murrant, @laf ... integrated in page navbar, is this ok?

screen shot 2017-12-04 at 8 37 00 am

@laf

This comment has been minimized.

Member

laf commented Dec 4, 2017

@crcro looks good.

@murrant

This comment has been minimized.

Member

murrant commented Dec 4, 2017

The header Health::Memory looks a little redundant. Is there a reason you didn't put navigation in the header. Think of them as tabs.

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 4, 2017

@murrant ... i think that this new version is more organized:

screen shot 2017-12-04 at 11 21 46 pm

@murrant

This comment has been minimized.

Member

murrant commented Dec 5, 2017

Thanks, now just to update the others.

@crcro

This comment has been minimized.

Contributor

crcro commented Dec 5, 2017

already pushed an update for others (device, wireless)

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Dec 9, 2017

Worked for me and looks good.

laf added some commits Dec 24, 2017

@laf laf merged commit 5995725 into librenms:master Dec 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 24, 2017

The inspection completed: No new issues

@crcro crcro deleted the crcro:webui-health-pages-refresh branch Dec 24, 2017

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.