New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: wireless pages refresh #7836

Merged
merged 2 commits into from Dec 24, 2017

Conversation

Projects
None yet
5 participants
@crcro
Contributor

crcro commented Dec 1, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

tried to give the wireless pages consistent look.

before:
screen shot 2017-12-01 at 4 18 24 pm

after:
screen shot 2017-12-01 at 4 17 38 pm

@kkrumm1 kkrumm1 added the WebUI label Dec 1, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 1, 2017

Member

@crcro what happened to the navigation across the top?

Member

murrant commented Dec 1, 2017

@crcro what happened to the navigation across the top?

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Dec 1, 2017

Contributor

@murrant ... i removed it, seems redundant as the top menu has the exact same functionality.

Contributor

crcro commented Dec 1, 2017

@murrant ... i removed it, seems redundant as the top menu has the exact same functionality.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 2, 2017

Member

i removed it, seems redundant as the top menu has the exact same functionality.

If you mean the navbar then that's too far to go to switch between sensors, the old links need to stay imho.

Member

laf commented Dec 2, 2017

i removed it, seems redundant as the top menu has the exact same functionality.

If you mean the navbar then that's too far to go to switch between sensors, the old links need to stay imho.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 4, 2017

Member

There is quite a difference between going through the top menu and having one click access. Please add them back, thanks.

Member

murrant commented Dec 4, 2017

There is quite a difference between going through the top menu and having one click access. Please add them back, thanks.

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Dec 4, 2017

Contributor

added back the in page links, more compact, to match others:

screen shot 2017-12-05 at 1 00 40 am

Contributor

crcro commented Dec 4, 2017

added back the in page links, more compact, to match others:

screen shot 2017-12-05 at 1 00 40 am

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Dec 4, 2017

The inspection completed: No new issues

@laf laf referenced this pull request Dec 7, 2017

Closed

Table updates tracking #7831

9 of 9 tasks complete
@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Dec 9, 2017

Member

Worked for me and looks good. 👍

Member

kkrumm1 commented Dec 9, 2017

Worked for me and looks good. 👍

@laf laf merged commit e7486d5 into librenms:master Dec 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@crcro crcro deleted the crcro:webui-wireless-pages-refresh branch Dec 24, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.